Skip to content

Commit

Permalink
fix(generic): document that the minimum Node version is 6
Browse files Browse the repository at this point in the history
  • Loading branch information
malept committed Dec 13, 2016
1 parent e76e282 commit 1f5ac7f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jump right in to Electron development.

# Getting Started

**Note**: Electron Forge requires Node 6 or above, plus git installed.

```bash
npm install -g electron-forge
electron-forge init my-new-app
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,8 @@
"electron-installer-debian": "^0.4.0",
"electron-installer-flatpak": "^0.4.0",
"electron-installer-redhat": "^0.3.0"
},
"engines": {
"node": ">= 6.0"
}
}
2 changes: 1 addition & 1 deletion src/electron-forge.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ checkSystem()
checker.succeed();
if (!goodSystem) {
console.error(('It looks like you are missing some dependencies you need to get Electron running.\n' +
'Make sure you have git installed and node.js version 4.0.0+').red);
'Make sure you have git installed and Node.js version 6.0.0+').red);
process.exit(1);
}

Expand Down
2 changes: 1 addition & 1 deletion src/util/check-system.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ export default async () =>
resolve(true);
});
})
.then(prev => Promise.resolve(prev && semver.gt(process.versions.node, '4.0.0')));
.then(prev => Promise.resolve(prev && semver.gt(process.versions.node, '6.0.0')));

0 comments on commit 1f5ac7f

Please sign in to comment.