Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License Agreement in Windows Installer #717

Closed
cbairy opened this issue Mar 15, 2019 · 1 comment
Closed

License Agreement in Windows Installer #717

cbairy opened this issue Mar 15, 2019 · 1 comment
Labels

Comments

@cbairy
Copy link

cbairy commented Mar 15, 2019

I am trying to show EULA (license agreement) in windows electron application. I have LICENSE.txt under the root of my project. This license agreement is not shown while we install the application. Is there a way to configure "electronWinstallerConfig" so that we can show a license agreement while we install Squirrel Windows application?

I am using electron-forge version 5.x.

My package.json looks like
{
"name": "MyApp",
"productName": "MyApp",
"version": "1.0.11",
"description": "My Electron application description",
"main": "src/index.js",
"scripts": {
"start": "electron-forge start",
"package": "electron-forge package",
"make": "electron-forge make",
"publish": "electron-forge publish",
"lint": "eslint src --color"
},
"keywords": [],
"author": "Chandrakanth",
"config": {
"forge": {
"make_targets": {
"win32": [
"squirrel"
],
"darwin": [
"dmg"
],
"linux": [
"deb",
"rpm"
]
},
"publish_targets": {
"win32": [
"nucleus-uploader"
],
"darwin": [
"nucleus-uploader"
]
},
"nucleus": {
"host": "http://nucleus-host:8888",
"appId": "2",
"channelId": "*",
"token": "
"
},
"electronPackagerConfig": {
"asar": true,
"extraResource": [
],
"packageManager": "yarn",
"version-string": {
"FileDescription": "MyApp",
"ProductName": "MyApp",
"CompanyName": "Chandrakanth"
},
"win32metadata": {
"FileDescription": "MyApp",
"ProductName": "MyApp",
"CompanyName": "Chandrakanth"
}
},
"electronWinstallerConfig": {
"name": "MyApp",
"loadingGif": "installation.gif"
},
"electronInstallerDebian": {},
"electronInstallerRedhat": {}
}
},
"dependencies": {
"async": "^2.6.1",
"better-queue": "^3.8.10",
"checksum": "^0.1.1",
"electron-compile": "^6.4.3",
"electron-is-dev": "^1.0.1",
"electron-log": "^2.2.17",
"electron-remote": "^1.3.0",
"electron-squirrel-startup": "^1.0.0",
"electron-updater": "^4.0.5",
"env": "0.0.2",
"ffi-napi": "^2.4.4",
"finalize": "^1.0.4",
"fs-jetpack": "^2.1.0",
"hazardous": "^0.3.0",
"hidefile": "^2.0.0",
"mime-types": "^2.1.21",
"mocha": "^5.2.0",
"node-machine-id": "^1.1.10",
"perf_hooks": "0.0.1",
"read-dir-and-stat": "^1.0.6",
"ref": "^1.3.5",
"ref-array": "^1.2.0",
"ref-struct": "^1.1.0",
"winattr": "2.0.0",
"windows-build-tools": "^5.0.0"
},
"devDependencies": {
"babel-plugin-transform-async-to-generator": "^6.24.1",
"babel-preset-env": "^1.7.0",
"babel-preset-react": "^6.24.1",
"electron-forge": "^5.2.4",
"electron-prebuilt-compile": "4.0.0",
"electron-winstaller": "^2.7.0",
"electron-wix-msi": "^2.1.1",
"eslint": "^3",
"eslint-config-airbnb": "^15",
"eslint-plugin-import": "^2",
"eslint-plugin-jsx-a11y": "^5",
"eslint-plugin-react": "^7",
"node-sass": "^4.10.0",
"nucleus-uploader": "^2.0.0"
}
}

Application folder structure looks like:
MyApp
--package.json
--LICENSE.txt
--src
--node_modules
--out
--.compilerc
--.eslintrc
I checked the usage of electron-winstaller in
https://github.com/electron/windows-installer#usage and did not see any necessary documentation to include license in the setting up of the application.

Am I missing any other configuration or is there a way to show license agreement by writing a script inside index.js just like we do for autoUpadte?

@malept
Copy link
Member

malept commented Mar 18, 2019

Someone else researched this for another Squirrel installer module last week for a different reason: electron-userland/electron-installer-windows#261 (comment)

The answer is basically that you need to handle this in your app, inside your main process.

@malept malept closed this as completed Mar 18, 2019
dsanders11 pushed a commit that referenced this issue Jan 14, 2023
Co-authored-by: VerteDinde <khammond@slack-corp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants