Update Electron dependencies for 3.x/4.x #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcastilloec
requested changes
Dec 10, 2018
There was a problem hiding this comment.
Based on what you mentioned in electron-userland/electron-installer-redhat#89 (comment) now I know how you got a list of dependencies for each version of electron. So, I went ahead and did exactly what you did, finding package names, and checking for dependencies and reverse-dependencies.
What I've notice is that we are missing libxss1 as a dependency for all versions, none of our current packages install that library which is listed as NEEDED. I also checked the official Atom, Slack and VSCode .deb installer and a couple of other electron based apps and the majority of them also list libxss1 as a dependency.
Besides that details, everything is great!
fcastilloec
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in electron-userland/electron-installer-redhat#89 for context.