Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release (revision) not being used in output filename #113

Closed
clarktlaugh opened this issue Apr 4, 2019 · 0 comments · Fixed by #114
Closed

Release (revision) not being used in output filename #113

clarktlaugh opened this issue Apr 4, 2019 · 0 comments · Fixed by #114

Comments

@clarktlaugh
Copy link

What version of electron-installer-redhat are you using?
1.0.1

What version of node and npm are you using?
node 8.11.2
npm 5.6.0

What operating system are you using?
Ubuntu

Can you compile the example app successfully?

Did not try

If not, paste here the output of the following commands:

$ git clone https://github.com/unindented/electron-installer-redhat.git
$ cd electron-installer-redhat/example
$ DEBUG='electron-installer-redhat' npm run build

What did you do? Please include the configuration you are using for electron-installer-redhat.

I am trying to build an RPM w/ the following configuration and command line:

command line:

node_modules/.bin/electron-installer-redhat  \
             --src dist/hpepmm-linux-x64  \
             --dest Output  \
             --options.version ${new_version}  \
             --config config.json

config.json:

{
   "name": "hpepmm",
   "arch": "x86_64",
   "productName": "XXXX Utility",
   "description": "Configuration utility for XXXX",
   "license": "LICENSE.txt",
   "bin": "hpepmm",
   "icon": "resources/icon.png",
   "categories": [
      "Utility"
   ]
}

What did you expect to happen?

The RPM is built with the following filename: hpepmm-0.7.1-1.x86_64.rpm

The filename should have the release in it (which is 1 by default -- it's in the spec file)

What actually happened?

The RPM is built with the following filename: hpepmm-0.7.1.x86_64.rpm
When I look at the details of the RPM, it reports:

Version: 0.7.1
Release: 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant