Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision fix #114

Merged
merged 3 commits into from
May 24, 2019
Merged

Revision fix #114

merged 3 commits into from
May 24, 2019

Conversation

fcastilloec
Copy link
Collaborator

It seems that the release number is not optional for RPM. As seen in https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/

The package release number MUST always be present while the others may or may not be depending on the situation.

This is probably a breaking change too.

This also fixes #113

@fcastilloec fcastilloec requested a review from malept April 4, 2019 20:57
@clarktlaugh
Copy link

Thank you!

@clarktlaugh
Copy link

Good afternoon -- do you have an ETA on when this might be able to be reviewed and merged? Anything I can do to help? Testing?

@malept
Copy link
Member

malept commented Apr 11, 2019

Sorry, I don't have an ETA on when I can review this. It is on my TODO list, but that TODO list is rather large right now.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience.

@malept malept merged commit dc75e94 into master May 24, 2019
@malept malept deleted the revision-fix branch May 24, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release (revision) not being used in output filename
3 participants