Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set permissions for suid sandbox helper #112

Merged
merged 4 commits into from
May 2, 2019
Merged

feat: set permissions for suid sandbox helper #112

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f80b917
feat: set permissions for suid sandbox helper
nornagon Mar 7, 2019
2b8e09c
refactor: use the -common method
malept Mar 8, 2019
263b28f
Update installer.js
nornagon Mar 8, 2019
bd85a99
Revert "Update installer.js"
nornagon Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/installer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,18 @@ class RedhatInstaller extends common.ElectronInstaller {
get specPath () {
return path.join(this.stagingDir, 'SPECS', `${this.options.name}.spec`)
}

/**
* Copy the application into the package.
*/
async copyApplication () {
await super.copyApplication()

// The sandbox helper executable must have the setuid (+s / 0o4000) bit set.
const sandboxHelperPath = path.join(this.stagingDir, 'chrome-sandbox')
if (await fs.exists(sandboxHelperPath))
await fs.chmod(sandboxHelperPath, 0o4755)
}

/**
* Creates macros file used by `rpmbuild`.
Expand Down