Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TypeScript definitions #72

Merged
merged 4 commits into from
Apr 13, 2020
Merged

feat: add TypeScript definitions #72

merged 4 commits into from
Apr 13, 2020

Conversation

malept
Copy link
Member

@malept malept commented Apr 13, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Also moves the API docs from a manually-curated Markdown file to the TypeScript definition, which also allows us to generate GitHub Pages (like Electron Packager's).

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #72 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          252       252           
=========================================
  Hits           252       252           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c10783...d830afa. Read the comment docs.

@malept malept merged commit 864a529 into master Apr 13, 2020
@malept malept deleted the typescript-definitions branch April 13, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant