Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid testing how rcedit works and just test the rcedit option transform #612

Merged
merged 1 commit into from
Mar 8, 2017

Conversation

malept
Copy link
Member

@malept malept commented Mar 7, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This should make the win32 tests run a bit faster since it's not running the whole packager function. Also gets rid of a devDependency 🎉

CC: @dmascord - this should help you write tests for #610.

@malept malept added the build-target:windows Bundling an Electron app specifically for Windows label Mar 7, 2017
@malept
Copy link
Member Author

malept commented Mar 7, 2017

FYI, running node test/win32 goes from 1m14s (master) to 10s (PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-target:windows Bundling an Electron app specifically for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant