Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No auto updater by default #82

Merged
merged 4 commits into from May 25, 2020
Merged

Conversation

bitdisaster
Copy link
Collaborator

After some reconsideration, the auto-updater will no be install as it would require to soften the NTFS access rights. That might not be desired if customers never plan to use the auto-updater.
With this change, the auto-updater and permissions will only be installed when the feature is installed. However, customers can also choose to install the auto-updater but keep it disabled initially by overwriting the MSI parameter AUTOUPDATEENABLED with a 0. The corresponding registry key can be later controlled via GPO

@coveralls
Copy link

coveralls commented May 19, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling c5664e5 on no-autoUpdater-by-default into bdee6cb on v3-feature-branch.

static/wix.xml Outdated Show resolved Hide resolved
static/wix.xml Outdated Show resolved Hide resolved
@bitdisaster bitdisaster merged commit 713dc35 into v3-feature-branch May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants