Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Include package-lock.json #192

Closed
stefnotch opened this issue Jul 19, 2022 · 5 comments · Fixed by #193
Closed

[Bug] Include package-lock.json #192

stefnotch opened this issue Jul 19, 2022 · 5 comments · Fixed by #193
Labels
bug Something isn't working

Comments

@stefnotch
Copy link
Contributor

Describe the bug

Adding the package-lock.json file to the .gitignore is probably not what users of the template expect. Essentially, an Electron app is an application, and not a library. And with an application, one definitely wants to be able to recreate it anytime.

However, if there's not package-lock.json, it's possible that some dependencies change, and suddenly, the previously-working application cannot be built anymore.

@stefnotch stefnotch added the bug Something isn't working label Jul 19, 2022
@caoxiemeihao
Copy link
Member

The earlier version v1.0.0 included pacakge-lock.json, but many people don't like npm they prefer pnpm yarn, which makes package-lock.json controversial.

@stefnotch
Copy link
Contributor Author

I still don't think that it should be in the .gitignore file, that's essentially setting oneself up for trouble.

@caoxiemeihao
Copy link
Member

Right now, the project contains only 8 dependencies. Remove package-lock.json and keep it consistent with the official vite-ts template.

@caoxiemeihao
Copy link
Member

You are right, you can submit a PR to remove *.lock from .gitignore.

@stefnotch stefnotch mentioned this issue Jul 19, 2022
4 tasks
@caoxiemeihao
Copy link
Member

putting *.lock in .gitignore is more useful to prevent the *.lock file from being carried when submitting PR.

caoxiemeihao added a commit that referenced this issue Jul 20, 2022
@caoxiemeihao caoxiemeihao mentioned this issue Jul 26, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants