Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken or deprecated apps #1548

Closed
VerteDinde opened this issue Oct 1, 2020 · 6 comments
Closed

Remove broken or deprecated apps #1548

VerteDinde opened this issue Oct 1, 2020 · 6 comments

Comments

@VerteDinde
Copy link
Member

Electron Apps has collected a great deal of apps over the years. However, many apps are now broken or no longer working, and thus should be removed from our directories. As part of Hacktoberfest, we'd like to clean up some of those apps.

You can find a guide for removing/disabling apps here: https://github.com/electron/apps/blob/master/contributing.md#removing-or-disabling-apps

Criteria for a Broken App:

  • Link to website no longer works
  • Last release was over 4 years ago
  • Using a version of Electron older than 3.x

Please limit PRs to removing a maximum of 5 apps per PR. This will allow others to also submit Hacktoberfest PRs, and keep our maintainers from becoming overwhelmed.

@murtajaziad
Copy link
Contributor

murtajaziad commented Oct 1, 2020

Hello, I would like to do this issue.

@TDDR
Copy link
Contributor

TDDR commented Oct 1, 2020

Hi, I would also like to contribute to this issue. I was just wondering if all 3 of the criteria need to be met in order to qualify as broken?

@vhashimotoo
Copy link
Contributor

@TDDR One criteria are enough to mark the app as delete candidate

@MrOsta
Copy link
Contributor

MrOsta commented Oct 23, 2020

Hey, I found some apps that don't have an electron on their package.json , should i disable it?

@Toinane
Copy link
Member

Toinane commented Oct 27, 2020

Hey, I found some apps that don't have an electron on their package.json , should i disable it?

Can you reference it here or in PR? If theses applications doesn't use Electron, they must be removed I my opinion

@electron electron deleted a comment from tussi003 Jan 4, 2021
@Toinane
Copy link
Member

Toinane commented Apr 7, 2021

I've removed a lot of disabled application here #1740 and I'll make a new check soon, I suppose we can now close this 👍

@Toinane Toinane unpinned this issue Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants
@VerteDinde @Toinane @vhashimotoo @murtajaziad @MrOsta @TDDR and others