Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asar list may lose some output if it's writing to a pipe #186

Closed
blahgeek opened this issue Feb 12, 2020 · 2 comments · Fixed by #194
Closed

asar list may lose some output if it's writing to a pipe #186

blahgeek opened this issue Feb 12, 2020 · 2 comments · Fixed by #194

Comments

@blahgeek
Copy link

blahgeek commented Feb 12, 2020

asar list example.asar | less may not produce the complete output under Linux.

I believe Process.exit(0) should not be called after console.log.

See https://nodejs.org/api/process.html#process_process_exit_code and https://nodejs.org/api/process.html#process_a_note_on_process_i_o

@malept
Copy link
Member

malept commented Feb 18, 2020

This is because for some bizarre reason, if you run asar list --is-pack example.asar without the process.exit(0), it prints out the help text as well (which is obviously undesirable). This appears to be some sort of quirk in the commander module which parses the command line arguments.

@malept malept added the bug label Feb 18, 2020
malept added a commit that referenced this issue Mar 23, 2020
malept added a commit that referenced this issue Mar 23, 2020
build(deps): upgrade commander to ^5.0.0

Fixes #186.
@electron-bot
Copy link

🎉 This issue has been resolved in version 3.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants