Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require Node 10.12.0 #191

Merged
merged 13 commits into from
Mar 10, 2020
Merged

feat: require Node 10.12.0 #191

merged 13 commits into from
Mar 10, 2020

Conversation

malept
Copy link
Member

@malept malept commented Feb 23, 2020

BREAKING CHANGE: Drops support for Node < 10.12.0

This allows us to drop two direct dependencies (cuint and mkdirp), plus I found a way to drop a third (tmp-promise) that was unrelated to the Node version change.

Also uses stream.pipeline (added in Node 10) which simplifies how Filesystem.prototype.insertFile is implemented.

@MarshallOfSound
Copy link
Member

This unreasonably concerns me as I don't think the asar tests are solid enough for this kind of change. I'd like electron's test suite to run against this version of asar before we consider publishing it

@malept
Copy link
Member Author

malept commented Feb 24, 2020

I'd like electron's test suite to run against this version of asar before we consider publishing it

Done: electron/electron#22351

The only check that failed was Archaeologist, which can be fixed with electron/archaeologist#16 ETA: This has been merged & Archaeologist passes.

@malept
Copy link
Member Author

malept commented Feb 25, 2020

Also want to point out that tests are passing, AppVeyor is a red herring due to #189 (comment)

@MarshallOfSound
Copy link
Member

cc @zcbenz

@zcbenz
Copy link
Member

zcbenz commented Mar 10, 2020

I changed Appveyor's setting to "Skip branches without appveyor.yml", so the appveyor errors should be gone in future.

@malept malept merged commit f1a29ba into master Mar 10, 2020
@malept malept deleted the node-10 branch March 10, 2020 21:13
@electron-bot
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants