-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: require Node 10.12.0 #191
Conversation
BREAKING CHANGE: Require Node >= 10.12.0
This unreasonably concerns me as I don't think the |
Done: electron/electron#22351
|
Also want to point out that tests are passing, AppVeyor is a red herring due to #189 (comment) |
cc @zcbenz |
I changed Appveyor's setting to "Skip branches without appveyor.yml", so the appveyor errors should be gone in future. |
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: Drops support for Node < 10.12.0
This allows us to drop two direct dependencies (
cuint
andmkdirp
), plus I found a way to drop a third (tmp-promise
) that was unrelated to the Node version change.Also uses
stream.pipeline
(added in Node 10) which simplifies howFilesystem.prototype.insertFile
is implemented.