fix: allowing nested empty directories. Fixes #245 and #144 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Oct 31, 2022
VerteDinde
approved these changes
Nov 3, 2022
|
@mmaietta Thanks for the PR! 🙇♀️ We'll get this merged and a new release cut for you |
|
🎉 This PR is included in version 3.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing nested empty directories, such as for the case with scoped node_modules.
Fixes #245 and #144
I tried to think of an additional test to add but I think this one was already supposed to cover this use case? https://github.com/electron/asar/tree/main/test/input/packthis-unicode-path/dir1
https://github.com/electron/asar/blob/main/test/api-spec.js#L84-L90