Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relative link error #308

Merged
merged 12 commits into from
May 2, 2024
Merged

fix: relative link error #308

Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b6930bf
fix: relative link error
ziqiangai Mar 27, 2024
44a7cda
feat: use resolve method
ziqiangai Mar 27, 2024
18b6e3f
feat: use resolve method
ziqiangai Mar 27, 2024
a173528
fix: lint error
ziqiangai Mar 27, 2024
4738c3f
fix: lint error
ziqiangai Mar 27, 2024
b05b255
fix: new implement handle link
ziqiangai Mar 28, 2024
d278f71
test(filesystem): add insertLink test
BlackHole1 Mar 28, 2024
880d020
fix test
BlackHole1 Mar 28, 2024
ad7d2d5
refactor: improve link path
BlackHole1 Mar 28, 2024
eaf970c
re-write logic
BlackHole1 Apr 28, 2024
c23fb27
Update test/filesystem-spec.js
erickzhao May 2, 2024
e901f4f
Update test/filesystem-spec.js
erickzhao May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/filesystem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,13 @@ class Filesystem {
}

insertLink (p) {
const symlink = fs.readlinkSync(p)
const parentPath = path.dirname(p)
const link = path.relative(fs.realpathSync(this.src), path.join(parentPath, symlink))
if (link.substr(0, 2) === '..') {
throw new Error(`${p}: file "${link}" links out of the package`)
const realSrcPath = fs.realpathSync(this.src)
const target = path.join(path.dirname(p), fs.readlinkSync(p))
const relativePath = path.relative(realSrcPath, fs.realpathSync(target))
if (relativePath.startsWith('..')) {
throw new Error(`${p}: file "${relativePath}" links out of the package`)
}
const link = path.relative(realSrcPath, target)
const node = this.searchNodeFromPath(p)
node.link = link
return link
Expand Down