Skip to content

Commit

Permalink
fix: broker test import URLSearchParams explicitly (#19)
Browse files Browse the repository at this point in the history
Works around an upstream typing issues with URL, URLSearchParams. Without this, the broker's tests fail when a type for URLSearchParams can't be found.

Looks like this might've broken as a side-effect of specifying ES2019 in tsconfig.base.json in f6254f8 ?

Xref: DefinitelyTyped/DefinitelyTyped#34960
  • Loading branch information
ckerr committed May 27, 2021
1 parent cc96ed4 commit 4a1900e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions modules/broker/test/broker.spec.ts
Expand Up @@ -2,6 +2,7 @@ import * as semver from 'semver';
import dayjs from 'dayjs';
import fetch from 'node-fetch';
import { v4 as mkuuid, validate as is_uuid } from 'uuid';
import { URLSearchParams } from 'url';

import { Broker } from '../src/broker';
import { Server } from '../src/server';
Expand Down
1 change: 1 addition & 0 deletions modules/shared/tsconfig.base.json
Expand Up @@ -12,5 +12,6 @@
"module": "CommonJS",
"moduleResolution": "node",
"esModuleInterop": true,
"types": ["jest", "node"]
}
}

0 comments on commit 4a1900e

Please sign in to comment.