Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

probot client testing is poor #81

Open
ckerr opened this issue Jul 1, 2021 · 3 comments
Open

probot client testing is poor #81

ckerr opened this issue Jul 1, 2021 · 3 comments
Assignees
@erickzhao
Labels
module:bot 🧪 tests Improvements or additions to tests

Comments

@ckerr
Copy link
Member

ckerr commented Jul 1, 2021

Right now the probot client's testing coverage is ~35%.

It's difficult to make changes that effect the probot client + other modules (or just the probot client itself) because it's difficult to test those changes.
@ckerr ckerr added the 🧪 tests Improvements or additions to tests label Jul 1, 2021
@ckerr
Copy link
Member Author

ckerr commented Jul 2, 2021

Partially addressed in #83

@erickzhao erickzhao mentioned this issue Jul 3, 2021
Merged
@erickzhao erickzhao self-assigned this Jul 5, 2021
@ckerr
Copy link
Member Author

ckerr commented Jul 13, 2021

@erickzhao bot coverage is at ~88% now. OK to close this ticket?

@erickzhao
Copy link
Member

@ckerr I think the core GitHub Client logic is in a good place, but we don't have any Broker API tests. I didn't write any pending #75.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erickzhao erickzhao

Labels
module:bot 🧪 tests Improvements or additions to tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ckerr @erickzhao