test: refactor probot client to be easier to test #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The probot client's state is now held in a ProbotClient class. This class can be instantiated in the spec so that it can be inspected. - Setting info and Probot can now be injected from a spec via the ProbotClient constructor - use @octokit/webhooks-types for octokit payload type safety and use type-fest for PartialDeep<> for building partial payloads safely.
|
This pull request introduces 1 alert when merging 90b734f into 6fc53a9 - view on LGTM.com new alerts:
|
eslint/no-unused-vars is superceded by the sibling rule in typescript-eslint
erickzhao
approved these changes
Jul 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take a stab at trying to improve the probot unit testing.
What's New
@octokit/webhooks-typesto add octokit payload type safety and. Use type-fest'sPartialDeep<>for building partial payloads safely. Your IDE will be happy!Context
I'm PRing this now since it's at a good stopping point and @erickzhao, who is back tomorrow, has expressed interest in working on the bot. So (a) I wanted to get his opinion on whether this looks like progress, and (b) want to hand over the baton so that we're not both hacking the same code. My goal is to use this for integration tests between the bot & the broker.