Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move issue parsing logic to bot module #84

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jul 2, 2021

Closes #82
Closes #42

Note that the only tests in the shared module were for the issue body parser. Since I don't want to remove the Jest infrastructure in place, I've just added a .gitkeep file so that the shared /test folder still exists in Git.

@erickzhao erickzhao marked this pull request as ready for review July 2, 2021 18:34
@ckerr ckerr merged commit 509d3a8 into main Jul 2, 2021
@ckerr ckerr deleted the refactor/bot-issue-parser branch July 2, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should issue-parser be in bot/ instead of shared/? Move issue parsing code to bot module
2 participants