Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron_mirror is not honored on OS X due to process.env being case-sensitive #5

Closed
jsbeckma opened this issue Aug 24, 2016 · 2 comments

Comments

@jsbeckma
Copy link
Contributor

It looks like process.env is case-insensitive on Windows but case-sensitive on OS X. When download-chromedriver.js runs on OS X, the process.env.npm_* variables are lower case and therefore process.env.NPM_CONFIG_ELECTRON_MIRROR equates to undefined and baseUrl defaults to https://github.com/electron/electron/release/download/v.

-- steps to reproduce --

npm config set electron_mirror http://nothingtoseehere.com
node ./download-chromedriver.js

The above should fail on OS X but does not.

I'm using:

  • OS X 10.11.6
  • node 4.4.7 (I've also tested it on 6.4.0 and the issue still exists)
  • npm 2.15.8
@jsbeckma
Copy link
Contributor Author

Created #6
This is the first public project I've contributed to so I hope my etiquette is correct. Cheers.

@kevinsawicki
Copy link
Contributor

Fixed by #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants