-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade dependencies to latest #59
Conversation
Yep: https://github.com/sindresorhus/got/blob/v10.7.0/documentation/migration-guides.md#renamed-options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, migrating to @electron/get
1.x will require folks to use Node 8.
Node 8 reached EOL at the end of 2019, so I think it'd be reasonable to expect a minimum of Node 10 from our users. Thoughts @malept @codebytere? |
ce9aa24
to
9a25a8c
Compare
9a25a8c
to
91d5743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with requiring Node 10, I just mention it because it would obviously require a major version bump.
Going to resolve your last issue and rebase the commit history. |
429c47c
to
c10702b
Compare
CircleCI seems to be failing on macOS, will try to resolve. |
4153bc4
to
960895f
Compare
CI now passing. Seems like you can't directly specify a |
This is what |
That works even better then, thanks! Will amend again. :) |
b224c05
to
c75f116
Compare
7458ee0
to
c927c62
Compare
c927c62
to
b244950
Compare
Closes #58
Migrates from
electron-download
to@electron/get
. Biggest motivation: GitHub will give a security warning for any new install of this package due to a vulnerability with the lastelectron-download
version'sminimist
dependency.Things to consider:
quiet
andstrictSSL
options are gone.rejectUnauthorized
seemed like somewhat of an equivalent to the latter. Please correct me if I'm wrong! @cc maleptasync/await
syntax.Edit: From discussion below, also:
extract-zip
to2.0.0
.node >= 10