Crash when removing the Tray icon

[raxityo]

• What operating system are you using? macOS High Sierra 10.13.4
• What version of Node.js is on your system? Reproduced in v8.9.3 and v9.11.1
• What is the version of electron-api-demos? Reproducible in master @ d9005b3

Steps to reproduce:

1. npm start
2. Go to "Put your app in the tray" sub section under "Native User Interface" section.
3. Click on "View Demo" button.
4. Click on the tray icon to open the context menu with one item: "Remove".
5. Click on the tray icon to close the context menu. (without clicking "Temove")
6. Click on "View Demo" button in the app to remove the system tray icon.
7. Click on "View Demo" button again to add the system tray icon.
8. Click on the tray icon and this time click on "Remove".
9. Observe Unexpected Crash with System alert "Electron quit unexpecetdly".

Note: The crash is reproducible in other arbitrary ways (open/close the tray icon) but these steps seemed to have reproduced it consistently.

Detailed Crash Report

Crash Report

[codebytere]

@raxityo seems to be failing a DCHECK here:

#
# Fatal error in ../../v8/src/api.h, line 357
# Debug check failed: allow_empty_handle || that != NULL.
#
Process 11745 stopped
* thread #1, name = 'CrBrowserMain', queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x0000000102438a22 libv8_libbase.dylib`v8::base::OS::Abort() + 18
libv8_libbase.dylib`v8::base::OS::Abort:
->  0x102438a22 <+18>: ud2
    0x102438a24 <+20>: nopw   %cs:(%rax,%rax)

libv8_libbase.dylib`v8::base::OS::DebugBreak:
    0x102438a30 <+0>:  pushq  %rbp
    0x102438a31 <+1>:  movq   %rsp, %rbp
Target 0: (Electron) stopped.

i'll keep digging.