Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Docs Time! #37

Merged
merged 7 commits into from Mar 10, 2016
Merged

Docs Time! #37

merged 7 commits into from Mar 10, 2016

Conversation

jlord
Copy link
Contributor

@jlord jlord commented Feb 27, 2016

This PRs adds and updates the docs for real life, all grown up, out in the real world!

  • CoC
  • Update readme
  • Application documentation
  • Issue templates

@jlord
Copy link
Contributor Author

jlord commented Feb 29, 2016

Over the weekend I was like this should totally have a diagram...and it's probably diagram-able, I'll do that. So I tried, I got this, and I'm not sure if it's worth including (is it even helpful?) something like this or in which ways it can be refined to actually be helpful to people? cc @simurai

screen shot 2016-02-29 at 2 18 35 pm

@simurai
Copy link
Contributor

simurai commented Mar 1, 2016

Nice! 👍 Ya, I think it's helpful understanding the directories and how things get loaded.

But this wouldn't be part of the content, it's specific to this demo app, right? Would it be part of the README.md? For people that try to understand how the demo app is built.

@jlord
Copy link
Contributor Author

jlord commented Mar 1, 2016

Would it be part of the README.md?

I was thinking of having it a part of the docs.md file?

@simurai
Copy link
Contributor

simurai commented Mar 2, 2016

Ahh.. yes, that makes sense.

@jlord
Copy link
Contributor Author

jlord commented Mar 2, 2016

I'm going to change some of the colors so that it matches the app itself a bit and then this should be ready for merge.

@jlord jlord mentioned this pull request Mar 3, 2016
42 tasks
@jlord
Copy link
Contributor Author

jlord commented Mar 3, 2016

Ok, I've updated it to make it match the app more. I've also added a bit more to the diagram, like numbers! Still not sure if my endeavor to graphically explain these types of things is worth it (in this case in beyond!). Six is repeated because these two things happen together 😁

@simurai how do you feel about the quality of this graphic? Do you want to mess with it? I can send you the .ai

@kevinsawicki do you think it explains the process correctly?

screen shot 2016-03-03 at 11 21 16 am

@kevinsawicki
Copy link
Contributor

do you think it explains the process correctly?

Diagrams looks great.

One small question, should there be two step 6s? Or should they be 6 and 7 instead?

@jlord
Copy link
Contributor Author

jlord commented Mar 3, 2016

should there be two step 6s? Or should they be 6 and 7 instead?

Yeah, so I wasn't sure what to do there because these two things are happening at the same time really.

Now that I'm thinking about this again, lemme try and move some things around so that the two blocks of text can be together with just one number.

@jlord
Copy link
Contributor Author

jlord commented Mar 3, 2016

Ok, how about this?

screen shot 2016-03-03 at 1 51 32 pm

@jlord
Copy link
Contributor Author

jlord commented Mar 3, 2016

And thinking about it some more, it doesn't make sense to differentiate the assets with a different color. Event though it contains non-js and non-html, everything in it belongs to the renderer process.

screen shot 2016-03-03 at 2 30 45 pm

@simurai
Copy link
Contributor

simurai commented Mar 4, 2016

I think looks great. But if you post the source file, I can fiddle with it a bit too.

Maybe try to make the connection between the arrow, number and text more clear. Not sure how.. would have to try it first.

@jlord
Copy link
Contributor Author

jlord commented Mar 4, 2016

Kewl, I'm going to 📧 it to you because I don't know if you prefer GH Box or Dropbox or if putting it in the repo is good/bad. I'll send it to you and let you decide 😀

@jlord
Copy link
Contributor Author

jlord commented Mar 9, 2016

Updating with @simurai's iterations (thank you!) :

screen shot 2016-03-08 at 8 05 49 pm


screen shot 2016-03-08 at 8 00 56 pm

I like the first one cause it's nicely sorted, though I'm not sure if having to match up the words with numbers is extra mental load? Maybe it's negligible?

What do people think?

@simurai
Copy link
Contributor

simurai commented Mar 9, 2016

having to match up the words with numbers is extra mental load?

It probably is extra mental. In the 2nd version you can move in a circle around it, so maybe still better?

@jlord
Copy link
Contributor Author

jlord commented Mar 9, 2016

In the 2nd version you can move in a circle around it, so maybe still better?

Yeah, that was something that I liked worked out when I was iterating on it. Let's go with that, you're second one. I'll add it to this branch.

@jlord jlord changed the title [WIP] Docs Time! Docs Time! Mar 9, 2016
jlord pushed a commit that referenced this pull request Mar 10, 2016
@jlord jlord merged commit 95934db into master Mar 10, 2016
@jlord jlord deleted the docs branch March 10, 2016 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants