TypeScript compiler regression #52
Comments
@MarshallOfSound so previously, Compiler behavior should be fixed to work without installation of TS but I still think typescript installation need to be optional instead of requiring it in behind of scene. maybe |
@kwonoj Fair enough, however I think that the change that was made should have been considered breaking. Anyone currently using |
@MarshallOfSound for versioning perspective, I do agree. actually, when I proposed PR (#50) I proposed it with breaking changes. |
@MarshallOfSound please review #53, I've added handler also made TS compiler as direct dependency to avoid regression in minor version bump. I'll create separate PR for making TS compiler as peerDep for major version bump. |
Sorry all, I didn't remember that we'd check the version, totally agree that this should be fixed asap |
Fixed, thanks Paul. |
The commit ffbd700 introduced a regression. The following repro steps fail with 5.3.0 and 5.3.1 and succeeds with 5.2.5.
Repro steps
electron-forge init something
cd something
electron-forge package
Expected
A package is created for the host platform & arch.
Actual
When
npm install
is run, this is one of the warnings (electron-compilers@5.3.1
is installed):The text was updated successfully, but these errors were encountered: