Skip to content

Commit

Permalink
chore: disable tests that require nut.js (#42006)
Browse files Browse the repository at this point in the history
* chore: disable tests that require nut.js

* fixup! chore: disable tests that require nut.js
  • Loading branch information
ckerr committed May 1, 2024
1 parent 36310b8 commit 05631ec
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 776 deletions.
2 changes: 2 additions & 0 deletions spec/api-browser-window-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6596,6 +6596,7 @@ describe('BrowserWindow module', () => {
afterEach(closeAllWindows);

ifit(hasCapturableScreen())('should allow the window to be dragged when enabled', async () => {
// FIXME: nut-js has been removed from npm; we need to find a replacement
// WOA fails to load libnut so we're using require to defer loading only
// on supported platforms.
// "@nut-tree\libnut-win32\build\Release\libnut.node is not a valid Win32 application."
Expand Down Expand Up @@ -6640,6 +6641,7 @@ describe('BrowserWindow module', () => {
});

ifit(hasCapturableScreen())('should allow the window to be dragged when no WCO and --webkit-app-region: drag enabled', async () => {
// FIXME: nut-js has been removed from npm; we need to find a replacement
// @ts-ignore: nut-js is an optional dependency so it may not be installed
const { mouse, straightTo, centerOf, Region, Button } = require('@nut-tree/nut-js') as typeof import('@nut-tree/nut-js');

Expand Down
6 changes: 4 additions & 2 deletions spec/disabled-tests.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@
"session module ses.cookies should set cookie for standard scheme",
"webFrameMain module WebFrame.visibilityState should match window state",
"reporting api sends a report for a deprecation",
"chromium features SpeechSynthesis should emit lifecycle events"
]
"chromium features SpeechSynthesis should emit lifecycle events",
"BrowserWindow module draggable regions should allow the window to be dragged when enabled",
"BrowserWindow module draggable regions should allow the window to be dragged when no WCO and --webkit-app-region: drag enabled"
]
3 changes: 0 additions & 3 deletions spec/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,6 @@
"ws": "^7.4.6",
"yargs": "^16.0.3"
},
"optionalDependencies": {
"@nut-tree/nut-js": "^3.1.2"
},
"resolutions": {
"nan": "file:../../third_party/nan",
"dbus-native/optimist/minimist": "1.2.7",
Expand Down
Loading

0 comments on commit 05631ec

Please sign in to comment.