address feedback from review

electron · Feb 12, 2019 · 1685c60 · 1685c60
1 parent 3b276c5
commit 1685c60
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc
@@ -1305,9 +1305,9 @@ v8::Local<v8::Promise> WebContents::SavePage(
     const content::SavePageType& save_type) {
   scoped_refptr<util::Promise> promise = new util::Promise(isolate());
   auto* handler = new SavePageHandler(web_contents(), promise);
-  bool success = handler->Handle(full_file_path, save_type);
 
-  if (!success)
+  const bool saveStarted = handler->Handle(full_file_path, save_type);
+  if (!saveStarted)
     promise->RejectWithErrorMessage("Failed to save the page");
 
   return promise->GetHandle();

diff --git a/docs/api/web-contents.md b/docs/api/web-contents.md
@@ -1544,7 +1544,7 @@ the cursor when dragging.
   * `HTMLComplete` - Save complete-html page.
   * `MHTML` - Save complete-html page as MHTML.
 
-Returns `Promise<void>` - resolves if the process of saving page has been initiated successfully.
+Returns `Promise<void>` - resolves if the process of saving page has been successfully completed.
 
 ```javascript
 const { BrowserWindow } = require('electron')
@@ -1554,7 +1554,7 @@ win.loadURL('https://github.com')
 
 win.webContents.on('did-finish-load', async () => {
   win.webContents.savePage('/tmp/test.html', 'HTMLComplete').then(() => {
-    console.log('Save page successfully')
+    console.log('Page was saved successfully.')
   }).catch(err => {
     console.log(err)
   })