add docs change and address review

electron · Apr 1, 2021 · 1fcd15c · 1fcd15c
1 parent a37b7f8
commit 1fcd15c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/docs/api/frameless-window.md b/docs/api/frameless-window.md
@@ -83,8 +83,10 @@ win.show()
   blur effect to the content below the window (i.e. other applications open on
   the user's system).
 * The window will not be transparent when DevTools is opened.
-* On Windows operating systems, transparent windows will not work when DWM is
+* On Windows operating systems,
+  * transparent windows will not work when DWM is
   disabled.
+  * transparent windows can not be maximized using the Windows system menu or by double clicking the title bar. The reasoning behind this can be seen on [this pull request](https://github.com/electron/electron/pull/28207).
 * On Linux, users have to put `--enable-transparent-visuals --disable-gpu` in
   the command line to disable GPU and allow ARGB to make transparent window,
   this is caused by an upstream bug that [alpha channel doesn't work on some

diff --git a/shell/browser/native_window_views_win.cc b/shell/browser/native_window_views_win.cc
@@ -336,8 +336,8 @@ bool NativeWindowViews::PreHandleMSG(UINT message,
       // This is handling the scenario where the menu might get triggered by the
       // user doing "alt + space" resulting in system maximization and restore
       // being used on transparent windows when that does not work.
-      HMENU menu = GetSystemMenu(GetAcceleratedWidget(), false);
       if (transparent()) {
+        HMENU menu = GetSystemMenu(GetAcceleratedWidget(), false);
         EnableMenuItem(menu, SC_MAXIMIZE,
                        MF_BYCOMMAND | MF_DISABLED | MF_GRAYED);
         EnableMenuItem(menu, SC_RESTORE,