refactor: make NativeWindowClientView::window_ a raw_ref

Xref: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++.md\#non_owning-pointers-in-class-fields Prefer const raw_ref<T> whenever the held pointer will never be null
electron · Jun 1, 2023 · 248b38f · 248b38f
1 parent 4f7e8d4
commit 248b38f
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/shell/browser/native_window_views.cc b/shell/browser/native_window_views.cc
@@ -164,8 +164,8 @@ class NativeWindowClientView : public views::ClientView {
  public:
   NativeWindowClientView(views::Widget* widget,
                          views::View* root_view,
-                         NativeWindowViews* window)
-      : views::ClientView(widget, root_view), window_(window) {}
+                         NativeWindowViews& window)
+      : views::ClientView{widget, root_view}, window_{window} {}
   ~NativeWindowClientView() override = default;
 
   // disable copy
@@ -178,7 +178,7 @@ class NativeWindowClientView : public views::ClientView {
   }
 
  private:
-  raw_ptr<NativeWindowViews> window_;
+  const raw_ref<NativeWindowViews> window_;
 };
 
 }  // namespace
@@ -1636,7 +1636,7 @@ bool NativeWindowViews::ShouldDescendIntoChildForEventHandling(
 }
 
 views::ClientView* NativeWindowViews::CreateClientView(views::Widget* widget) {
-  return new NativeWindowClientView{widget, GetContentsView(), this};
+  return new NativeWindowClientView{widget, GetContentsView(), *this};
 }
 
 std::unique_ptr<views::NonClientFrameView>