Skip to content

Commit

Permalink
build: actually show github upload output if verbose is true. (#40397)
Browse files Browse the repository at this point in the history
* build: actually show github upload output if verbose is true.

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

* chore: fixup lint

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
  • Loading branch information
trop[bot] and jkleinsc committed Nov 1, 2023
1 parent 92c9342 commit 35a9e69
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions script/release/uploaders/upload.py
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,10 @@ def upload_io_to_github(release, filename, filepath, version):
(filename))
script_path = os.path.join(
ELECTRON_DIR, 'script', 'release', 'uploaders', 'upload-to-github.ts')
execute([TS_NODE, script_path, filepath, filename, str(release['id']),
version])
upload_gh_output = execute([TS_NODE, script_path, filepath, filename,
str(release['id']), version])
if is_verbose_mode():
print(upload_gh_output)


def upload_sha256_checksum(version, file_path, key_prefix=None):
Expand Down

0 comments on commit 35a9e69

Please sign in to comment.