refactor: add WebViewGuestDelegate::GetGuestDelegateWeakPtr()

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/4515455 This approach copied from GuestViewBase::GetGuestDelegateWeakPtr() approach in that same commit.
electron · May 16, 2023 · 3f3ab39 · 3f3ab39
1 parent 9b53f3c
commit 3f3ab39
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/shell/browser/web_view_guest_delegate.cc b/shell/browser/web_view_guest_delegate.cc
@@ -124,4 +124,9 @@ WebViewGuestDelegate::CreateNewGuestWindow(
   return guest_contents;
 }
 
+base::WeakPtr<content::BrowserPluginGuestDelegate>
+WebViewGuestDelegate::GetGuestDelegateWeakPtr() {
+  return weak_ptr_factory_.GetWeakPtr();
+}
+
 }  // namespace electron
diff --git a/shell/browser/web_view_guest_delegate.h b/shell/browser/web_view_guest_delegate.h
@@ -38,6 +38,8 @@ class WebViewGuestDelegate : public content::BrowserPluginGuestDelegate,
   content::WebContents* GetOwnerWebContents() final;
   std::unique_ptr<content::WebContents> CreateNewGuestWindow(
       const content::WebContents::CreateParams& create_params) final;
+  base::WeakPtr<content::BrowserPluginGuestDelegate> GetGuestDelegateWeakPtr()
+      final;
 
   // WebContentsZoomController::Observer:
   void OnZoomLevelChanged(content::WebContents* web_contents,
@@ -56,6 +58,8 @@ class WebViewGuestDelegate : public content::BrowserPluginGuestDelegate,
   raw_ptr<WebContentsZoomController> embedder_zoom_controller_ = nullptr;
 
   raw_ptr<api::WebContents> api_web_contents_ = nullptr;
+
+  base::WeakPtrFactory<WebViewGuestDelegate> weak_ptr_factory_{this};
 };
 
 }  // namespace electron