Skip to content

Commit

Permalink
perf: remove GC timer that fired once per minute. (#26051)
Browse files Browse the repository at this point in the history
Co-authored-by: Charles Kerr <charles@charleskerr.com>
  • Loading branch information
trop[bot] and ckerr committed Oct 20, 2020
1 parent 139e203 commit 65fdfc1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions shell/browser/electron_browser_main_parts.cc
Expand Up @@ -471,11 +471,6 @@ void ElectronBrowserMainParts::PreMainMessageLoopRun() {
ui::TouchFactory::SetTouchDeviceListFromCommandLine();
#endif

// Start idle gc.
gc_timer_.Start(FROM_HERE, base::TimeDelta::FromMinutes(1),
base::BindRepeating(&v8::Isolate::LowMemoryNotification,
base::Unretained(js_env_->isolate())));

content::WebUIControllerFactory::RegisterFactory(
ElectronWebUIControllerFactory::GetInstance());

Expand Down
2 changes: 0 additions & 2 deletions shell/browser/electron_browser_main_parts.h
Expand Up @@ -160,8 +160,6 @@ class ElectronBrowserMainParts : public content::BrowserMainParts {
std::unique_ptr<ElectronExtensionsBrowserClient> extensions_browser_client_;
#endif

base::RepeatingTimer gc_timer_;

// List of callbacks should be executed before destroying JS env.
std::list<base::OnceClosure> destructors_;

Expand Down

0 comments on commit 65fdfc1

Please sign in to comment.