Update shell/common/gin_converters/usb_protected_classes_converter.h

Co-authored-by: Charles Kerr <charles@charleskerr.com>
electron · May 15, 2023 · 85141a9 · 85141a9
1 parent 3e5df17
commit 85141a9
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/shell/common/gin_converters/usb_protected_classes_converter.h b/shell/common/gin_converters/usb_protected_classes_converter.h
@@ -32,10 +32,11 @@ struct Converter<electron::ElectronPermissionManager::USBProtectedClasses> {
       v8::Isolate* isolate,
       const electron::ElectronPermissionManager::USBProtectedClasses& classes) {
     std::vector<std::string> class_strings;
-    for (auto itr : classes) {
-      for (auto const& [usb_class, name] : ClassMapping) {
+    class_strings.reserve(std::size(classes));
+    for (const auto& itr : classes) {
+      for (const auto& [usb_class, name] : ClassMapping) {
         if (usb_class == itr)
-          class_strings.push_back(static_cast<std::string>(name));
+          class_strings.emplace_back(name);
       }
     }
     return gin::ConvertToV8(isolate, class_strings);