When calling menu item's click callback, pass the item object.

electron · Aug 14, 2013 · 971b72c · 971b72c
1 parent f267a78
commit 971b72c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/browser/api/lib/menu-item.coffee b/browser/api/lib/menu-item.coffee
@@ -20,9 +20,9 @@ class MenuItem
     throw new Error('Unknown menu type') if MenuItem.types.indexOf(@type) is -1
 
     @commandId = ++nextCommandId
-    @click = ->
+    @click = =>
       if typeof click is 'function'
-        click()
+        click.apply this, arguments
       else if typeof selector is 'string'
         Menu.sendActionToFirstResponder selector
 

diff --git a/browser/api/lib/menu.coffee b/browser/api/lib/menu.coffee
@@ -37,7 +37,9 @@ Menu::insert = (pos, item) ->
       isCommandIdEnabled: (commandId) => @commandsMap[commandId]?.enabled
       isCommandIdVisible: (commandId) => @commandsMap[commandId]?.visible
       getAcceleratorForCommandId: (commandId) => @commandsMap[commandId]?.accelerator
-      executeCommand: (commandId) => @commandsMap[commandId]?.click()
+      executeCommand: (commandId) =>
+        activeItem = @commandsMap[commandId]
+        activeItem.click(activeItem) if activeItem?
   @items.splice pos, 0, item
   @commandsMap[item.commandId] = item