Skip to content

Commit

Permalink
refactor: remove unused switches (#38531)
Browse files Browse the repository at this point in the history
* refactor: remove unused declaration of electron::kSHA1Certificate

usage removed in 13a1d79

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: remove unused declaration of electron::kSHA1MajorDescription

usage removed in 13a1d79

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: remove unused declaration of electron::kSHA1MinorDescription

usage removed in 13a1d79

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: remove unused declaration of electron::kCertificateError

usage removed in 13a1d79

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: remove unused declaration of electron::kValidCertificate

usage removed in 13a1d79

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: remove unused declaration of electron::kValidCertificateDescription

usage removed in 13a1d79

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: remove unused declaration of electron::kSecureProtocol, kSecureProtocolDescription

usage removed in 497f5a1

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: remove electron::options::kPreloadScripts

removed in bad8d5e

Co-authored-by: Charles Kerr <charles@charleskerr.com>

* refactor: remove electron::options::kImageAnimationPolicy

removed in 385d0f5

Co-authored-by: Charles Kerr <charles@charleskerr.com>

---------

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
  • Loading branch information
trop[bot] and ckerr committed May 31, 2023
1 parent 54fe508 commit a21fa57
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 33 deletions.
16 changes: 0 additions & 16 deletions shell/common/electron_constants.cc
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,6 @@ namespace electron {
const char kBrowserForward[] = "browser-forward";
const char kBrowserBackward[] = "browser-backward";

const char kSHA1Certificate[] = "SHA-1 Certificate";
const char kSHA1MajorDescription[] =
"The certificate for this site expires in 2017 or later, "
"and the certificate chain contains a certificate signed using SHA-1.";
const char kSHA1MinorDescription[] =
"The certificate for this site expires in 2016, "
"and the certificate chain contains a certificate signed using SHA-1.";
const char kCertificateError[] = "Certificate Error";
const char kValidCertificate[] = "Valid Certificate";
const char kValidCertificateDescription[] =
"The connection to this site is using a valid, trusted server certificate.";
const char kSecureProtocol[] = "Secure TLS connection";
const char kSecureProtocolDescription[] =
"The connection to this site is using a strong protocol version "
"and cipher suite.";

const char kDeviceVendorIdKey[] = "vendorId";
const char kDeviceProductIdKey[] = "productId";
const char kDeviceSerialNumberKey[] = "serialNumber";
Expand Down
10 changes: 0 additions & 10 deletions shell/common/electron_constants.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,6 @@ namespace electron {
extern const char kBrowserForward[];
extern const char kBrowserBackward[];

// Strings describing Chrome security policy for DevTools security panel.
extern const char kSHA1Certificate[];
extern const char kSHA1MajorDescription[];
extern const char kSHA1MinorDescription[];
extern const char kCertificateError[];
extern const char kValidCertificate[];
extern const char kValidCertificateDescription[];
extern const char kSecureProtocol[];
extern const char kSecureProtocolDescription[];

// Keys for Device APIs
extern const char kDeviceVendorIdKey[];
extern const char kDeviceProductIdKey[];
Expand Down
5 changes: 0 additions & 5 deletions shell/common/options_switches.cc
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,6 @@ const char kZoomFactor[] = "zoomFactor";
// Script that will be loaded by guest WebContents before other scripts.
const char kPreloadScript[] = "preload";

const char kPreloadScripts[] = "preloadScripts";

// Enable the node integration.
const char kNodeIntegration[] = "nodeIntegration";

Expand Down Expand Up @@ -173,9 +171,6 @@ const char kJavaScript[] = "javascript";
// Enables image support.
const char kImages[] = "images";

// Image animation policy.
const char kImageAnimationPolicy[] = "imageAnimationPolicy";

// Make TextArea elements resizable.
const char kTextAreasAreResizable[] = "textAreasAreResizable";

Expand Down
2 changes: 0 additions & 2 deletions shell/common/options_switches.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ extern const char kOverlayHeight[];
// WebPreferences.
extern const char kZoomFactor[];
extern const char kPreloadScript[];
extern const char kPreloadScripts[];
extern const char kNodeIntegration[];
extern const char kContextIsolation[];
extern const char kExperimentalFeatures[];
Expand All @@ -86,7 +85,6 @@ extern const char kNodeIntegrationInSubFrames[];
extern const char kDisableHtmlFullscreenWindowResize[];
extern const char kJavaScript[];
extern const char kImages[];
extern const char kImageAnimationPolicy[];
extern const char kTextAreasAreResizable[];
extern const char kWebGL[];
extern const char kNavigateOnDragDrop[];
Expand Down

0 comments on commit a21fa57

Please sign in to comment.