Skip to content

Commit

Permalink
refactor: make ELECTRON_INSPECTOR_SELECT_FILE async
Browse files Browse the repository at this point in the history
  • Loading branch information
miniak committed Mar 1, 2019
1 parent 9eac6e6 commit a757e25
Showing 1 changed file with 13 additions and 19 deletions.
32 changes: 13 additions & 19 deletions lib/browser/chrome-devtools.js
Expand Up @@ -3,9 +3,12 @@
const { dialog, Menu } = require('electron')
const fs = require('fs')
const url = require('url')
const util = require('util')

const ipcMainUtils = require('@electron/internal/browser/ipc-main-internal-utils')

const readFile = util.promisify(fs.readFile)

const convertToMenuTemplate = function (event, items) {
return items.map(function (item) {
const transformed = item.type === 'subMenu' ? {
Expand Down Expand Up @@ -82,25 +85,16 @@ ipcMainUtils.handle('ELECTRON_INSPECTOR_CONTEXT_MENU', function (event, items, i
menu.popup({ window })
})

ipcMainUtils.handle('ELECTRON_INSPECTOR_SELECT_FILE', function (event) {
return new Promise((resolve, reject) => {
assertChromeDevTools(event.sender, 'window.UI.createFileSelectorElement()')

dialog.showOpenDialog({}, function (files) {
if (files) {
const path = files[0]
fs.readFile(path, (error, data) => {
if (error) {
reject(error)
} else {
resolve([path, data])
}
})
} else {
resolve([])
}
})
})
ipcMainUtils.handle('ELECTRON_INSPECTOR_SELECT_FILE', async function (event) {
assertChromeDevTools(event.sender, 'window.UI.createFileSelectorElement()')

const files = await dialog.showOpenDialog({})
if (!files) return []

const path = files[0]
const data = await readFile(path)

return [path, data]
})

ipcMainUtils.handle('ELECTRON_INSPECTOR_CONFIRM', function (event, message, title) {
Expand Down

0 comments on commit a757e25

Please sign in to comment.