ci: fix flaky test on arm (5-0-x) (#19806)

* ci: update docker options for arm testing
electron · Aug 16, 2019 · c00f715 · c00f715
1 parent 9c2d9ba
commit c00f715
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 5 deletions.
diff --git a/spec/api-web-contents-view-spec.js b/spec/api-web-contents-view-spec.js
@@ -38,8 +38,9 @@ describe('WebContentsView', () => {
       const appPath = path.join(__dirname, 'fixtures', 'api', 'leak-exit-webcontentsview.js')
       const electronPath = remote.getGlobal('process').execPath
       const appProcess = ChildProcess.spawn(electronPath, [appPath])
-      const [code] = await emittedOnce(appProcess, 'close')
+      const [code, message] = await emittedOnce(appProcess, 'close')
       expect(code).to.equal(0)
+      expect(message).to.be.null()
     })
   })
 })
diff --git a/spec/fixtures/api/leak-exit-webcontentsview.js b/spec/fixtures/api/leak-exit-webcontentsview.js
@@ -3,5 +3,8 @@ app.on('ready', function () {
   const web = webContents.create({})
   new WebContentsView(web)  // eslint-disable-line
 
-  process.nextTick(() => app.quit())
+  process.nextTick(() => {
+    console.log('Quitting app')
+    app.quit()
+  })
 })
diff --git a/vsts-arm32v7.yml b/vsts-arm32v7.yml
@@ -2,6 +2,7 @@ resources:
   containers:
   - container: arm32v7-test-container
     image: electronbuilds/arm32v7:0.0.2
+    options: --shm-size 128m
 
 jobs:
 - job: Test_Arm32v7

diff --git a/vsts-arm64v8.yml b/vsts-arm64v8.yml
@@ -1,9 +1,8 @@
 resources:
   containers:
   - container: arm64v8-test-container
-    image: electronbuilds/arm64v8:0.0.4
-    env:
-      RUN_NATIVE_MKSNAPSHOT: true
+    image: electronbuilds/arm64v8:0.0.5
+    options: --shm-size 128m
 
 jobs:
 - job: Test_Arm64