-
Notifications
You must be signed in to change notification settings - Fork 15k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
c652803
commit c06ea18
Showing
2 changed files
with
22 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
patches/node/build_define_libcpp_abi_namespace_as_cr_to_align_with_chromium.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
From: Samuel Attard <sattard@salesforce.com> | ||
Date: Mon, 6 Jun 2022 14:46:40 -0700 | ||
Subject: build: define _LIBCPP_ABI_NAMESPACE as Cr to align with chromium | ||
|
||
Without this define native modules will be built trying to link to _LIBCPP_ABI_NAMESPACE which is the default name, chromium overrides this to Cr for PDB size reasons but they override it on all platforms. Setting this define allows native modules to actually work. This should not be upstreamed as it is Electron specific. | ||
|
||
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/3655638 | ||
|
||
diff --git a/common.gypi b/common.gypi | ||
index fd4e0b38eb6ecf81b23186ec663499d1e685fdf8..a737e37ba0d4fb76e2f0e170781e56129510d34a 100644 | ||
--- a/common.gypi | ||
+++ b/common.gypi | ||
@@ -288,6 +288,7 @@ | ||
'V8_DEPRECATION_WARNINGS', | ||
'V8_IMMINENT_DEPRECATION_WARNINGS', | ||
'_GLIBCXX_USE_CXX11_ABI=1', | ||
+ '_LIBCPP_ABI_NAMESPACE=Cr', | ||
], | ||
|
||
# Forcibly disable -Werror. We support a wide range of compilers, it's |