Skip to content

Commit

Permalink
test: specify target arch on mksnapshot (#21871)
Browse files Browse the repository at this point in the history
  • Loading branch information
John Kleinschmidt committed Jan 23, 2020
1 parent dc2fcff commit c92edc8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions script/verify-mksnapshot.py
Expand Up @@ -7,6 +7,7 @@
import subprocess
import sys

from lib.config import get_target_arch
from lib.util import get_electron_branding, rm_rf, scoped_cwd

PROJECT_NAME = get_electron_branding()['project_name']
Expand All @@ -28,6 +29,8 @@ def main():
mkargs = [ get_binary_path('mksnapshot', app_path), \
SNAPSHOT_SOURCE, '--startup_blob', 'snapshot_blob.bin', \
'--no-native-code-counters', '--turbo_instruction_scheduling' ]
if get_target_arch() == 'ia32':
mkargs.append('--target_arch=x86')
subprocess.check_call(mkargs)
print('ok mksnapshot successfully created snapshot_blob.bin.')
context_snapshot = 'v8_context_snapshot.bin'
Expand Down

0 comments on commit c92edc8

Please sign in to comment.