fix: do not increase ref-counting in wrong thread (#16738)

electron · Feb 6, 2019 · d53b516 · d53b516
1 parent ff461d9
commit d53b516
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/atom/browser/api/atom_api_cookies.cc b/atom/browser/api/atom_api_cookies.cc
@@ -195,7 +195,7 @@ void RemoveCookieOnIO(scoped_refptr<net::URLRequestContextGetter> getter,
                       const std::string& name,
                       scoped_refptr<util::Promise> promise) {
   GetCookieStore(getter)->DeleteCookieAsync(
-      url, name, base::BindOnce(ResolvePromiseInUI, promise));
+      url, name, base::BindOnce(ResolvePromiseInUI, std::move(promise)));
 }
 
 // Resolves/rejects the |promise| in UI thread.
@@ -219,7 +219,7 @@ void FlushCookieStoreOnIOThread(
     scoped_refptr<net::URLRequestContextGetter> getter,
     scoped_refptr<util::Promise> promise) {
   GetCookieStore(getter)->FlushStore(
-      base::BindOnce(ResolvePromiseInUI, promise));
+      base::BindOnce(ResolvePromiseInUI, std::move(promise)));
 }
 
 // Sets cookie with |details| in IO thread.