Skip to content

Commit

Permalink
build: ensure that mksnapshot for Apple Silicon has all of the needed…
Browse files Browse the repository at this point in the history
… files for snapshot generation (#29338)

* build: include mksnapshot args in arm64 mksnapshot.zip

* get gen/v8/embedded.S from proper location

(cherry picked from commit d0b9a93)
  • Loading branch information
jkleinsc committed May 26, 2021
1 parent c4b04c5 commit e5d7c02
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,7 @@ step-electron-build: &step-electron-build
ninja -C out/Default electron:electron_mksnapshot_zip -j $NUMBER_OF_NINJA_PROCESSES
ninja -C out/Default tools/v8_context_snapshot -j $NUMBER_OF_NINJA_PROCESSES
gn desc out/Default v8:run_mksnapshot_default args > out/Default/mksnapshot_args
(cd out/Default; zip mksnapshot.zip mksnapshot_args clang_x64_v8_arm64/gen/v8/embedded.S)
rm -rf out/Default/clang_x64_v8_arm64/obj
# Regenerate because we just deleted some ninja files
Expand Down

0 comments on commit e5d7c02

Please sign in to comment.