fix: race-condition in electron.net (#27938)

electron · Mar 1, 2021 · e7e1801 · e7e1801
1 parent 0baf999
commit e7e1801
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/browser/api/net.ts b/lib/browser/api/net.ts
@@ -119,10 +119,13 @@ class IncomingMessage extends Readable {
       this._shouldPush = this.push(chunk);
     }
     if (this._shouldPush && this._resume) {
-      this._resume();
       // Reset the callback, so that a new one is used for each
-      // batch of throttled data
+      // batch of throttled data. Do this before calling resume to avoid a
+      // potential race-condition
+      const resume = this._resume;
       this._resume = null;
+
+      resume();
     }
   }