fix web dialog helper build

electron · Feb 14, 2019 · ee3ee12 · ee3ee12
1 parent 43351a4
commit ee3ee12
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/atom/browser/web_dialog_helper.cc b/atom/browser/web_dialog_helper.cc
@@ -53,10 +53,10 @@ class FileSelectHelper : public base::RefCounted<FileSelectHelper>,
         new atom::util::Promise(isolate);
 
     file_dialog::ShowOpenDialog(settings, promise);
-    promise->GetHandle()->Then(
+    ignore_result(promise->GetHandle()->Then(
         context,
-        mate::ConvertToV8(
-            isolate, base::Bind(&FileSelectHelper::OnOpenDialogDone, this)));
+        v8::Local<v8::Function>::Cast(mate::ConvertToV8(
+            isolate, base::Bind(&FileSelectHelper::OnOpenDialogDone, this)))));
   }
 
   void ShowSaveDialog(const file_dialog::DialogSettings& settings) {