Skip to content

Commit

Permalink
build: upload sentry src bundles to symbol S3 bucket (#22619)
Browse files Browse the repository at this point in the history
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
  • Loading branch information
trop[bot] and MarshallOfSound committed Mar 9, 2020
1 parent d4a79bc commit ee5d524
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .circleci/config.yml
Expand Up @@ -598,6 +598,8 @@ step-maybe-generate-breakpad-symbols: &step-maybe-generate-breakpad-symbols
if [ "$GENERATE_SYMBOLS" == "true" ]; then
cd src
ninja -C out/Default electron:electron_symbols
cd out/Default/breakpad_symbols
find . -name \*.sym -print0 | xargs -0 npx @sentry/cli@1.51.1 difutil bundle-sources
fi
step-maybe-zip-symbols: &step-maybe-zip-symbols
Expand Down
2 changes: 1 addition & 1 deletion script/release/uploaders/upload-symbols.py
Expand Up @@ -30,7 +30,7 @@ def main():
run_symstore(pdb, SYMBOLS_DIR, PRODUCT_NAME)
files = glob.glob(SYMBOLS_DIR + '/*.pdb/*/*.pdb')
else:
files = glob.glob(SYMBOLS_DIR + '/*/*/*.sym')
files = glob.glob(SYMBOLS_DIR + '/*/*/*.sym') + glob.glob(SYMBOLS_DIR + '/*/*/*.src.zip')

# The file upload needs to be atom-shell/symbols/:symbol_name/:hash/:symbol
os.chdir(SYMBOLS_DIR)
Expand Down

0 comments on commit ee5d524

Please sign in to comment.