Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should C++ Redistributable dlls in Electron 1.7 be packaged with the application? #10291

Closed
Tyriar opened this issue Aug 17, 2017 · 3 comments
Closed

Comments

@Tyriar
Copy link
Contributor

Tyriar commented Aug 17, 2017

Since 1.7 there are a bunch of new dlls in node_modules/electron/dist which look like the C++ Redistributable VS 2015 dlls. Should these be included with packaged applications? If so, are there any links/context to why this change was made?

Repro:

git clone https://github.com/electron/electron-quick-start
cd electron-quick-start
npm install
# Notice node_modules\electron\dist does not contain the dlls as
# electron-quick-start uses 1.6

# Change the electron dependency to 1.7.6
npm i -g rimraf
rimraf node_modules
npm i
# node_modules\electron\dist now contains additional dlls

dlls in question:

api-ms-*.dll
msvcp140.dll
vcruntime140.dll

image

@enlight
Copy link
Contributor

enlight commented Aug 18, 2017

As of Electron 1.7.4 the CRT is dynamically linked once again, all those extra dlls are part of the UCRT infrastructure. You can find the reasons for the switch in #9443.

@enlight enlight closed this as completed Aug 18, 2017
@Tyriar
Copy link
Contributor Author

Tyriar commented Aug 18, 2017

Thanks for the link 😃

@miniak
Copy link
Contributor

miniak commented Oct 17, 2017

The UCRT DLLs are "only" required for Windows 7 and 8. It became a system component in Windows 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants