Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems running bootstrap.py on Windows #10337

Closed
Tyriar opened this issue Aug 23, 2017 · 11 comments
Closed

Problems running bootstrap.py on Windows #10337

Tyriar opened this issue Aug 23, 2017 · 11 comments

Comments

@Tyriar
Copy link
Contributor

Tyriar commented Aug 23, 2017

I'm trying to build Electron on Windows to investigate #10188 but I'm running into a problem in bootstrap.py. Here's the error:

>python script\bootstrap.py -v
...
Downloading libchromiumcontent-static.zip...
https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent/win/x64/349396d62b4dece64c95727e2bbfb20dda987241/libchromiumcontent-static.zip
...................................................................................................................................................................
...................................................................................................................................................................
...................................................................................................................................................................
...................................................................................................................................................................
...................................................................................................................................................................
...................................................................................................................................................................
...................................................................................................................................................................
...................................................................................................................................................................
...................................................................................................................................................................
...................................................................................................................................................................
...................................................................................................................................................................
.................................
Extracting...
C:\Python27\python.exe C:\Users\daimms.REDMOND\Documents\dev\forks\electron\script\update.py
gyp: vendor\node\deps\zlib\zlib.gyp not found (cwd: C:\Users\daimms.REDMOND\Documents\dev\forks\electron)
ggyp: vendor\node\deps\uv\uv.gyp not found (cwd: C:\Users\daimms.REDMOND\Documents\dev\forks\electron)
yp: vendor\node\node.gyp not found (cwd: C:\Users\daimms.REDMOND\Documents\dev\forks\electron)
None
Traceback (most recent call last):
  File "script\bootstrap.py", line 261, in <module>
    sys.exit(main())
  File "script\bootstrap.py", line 65, in main
    run_update(defines, args.msvs)
  File "script\bootstrap.py", line 238, in run_update
    execute_stdout(args)
  File "C:\Users\daimms.REDMOND\Documents\dev\forks\electron\script\lib\util.py", line 184, in execute_stdout
    raise e
subprocess.CalledProcessError: Command '['C:\\Python27\\python.exe', 'C:\\Users\\daimms.REDMOND\\Documents\\dev\\forks\\electron\\script\\update.py']' returned non
-zero exit status 1

I believe I have all the prerequisites installed:

  • Windows 10 version 1703, OS build 15063.540
  • Visual Studio Professional 2015 Update 3
    image
  • Python 2.7.13
  • Node.js 7.9.0
  • Git 2.13.2.windows.1
@bpasero
Copy link
Contributor

bpasero commented Aug 24, 2017

@Tyriar I just tried the build instructions and it went smooth on my Win10 box. However, I remember seeing issues like that previously where the bootstrap was not finishing correctly.

My setup:

  • Python 2.7
  • node.js 6.9.4
  • Windows 10 version 1703 OS build 15063.540)
  • Visual Studio Community Edition 2015 Update 3 (same version as you)

@bpasero
Copy link
Contributor

bpasero commented Aug 24, 2017

One downside of #10188 is that I cannot reproduce from the debug version, only the release version...

@oceangravity
Copy link

Same issue here. Same prerequisites.

@DiegoBM
Copy link

DiegoBM commented Sep 9, 2017

Same issues here

@DiegoBM
Copy link

DiegoBM commented Sep 11, 2017

Anything on this anyone? Completely unable to build electron on windows

@taha
Copy link

taha commented Sep 11, 2017

@DiegoBM @jcgalindo I had this issue a couple of days ago on Windows, and the issue was actually to do with crazy long filenames which git config --system core.longpaths true fixed for me. Make sure to delete all previously created files from failed bootstrap attempts.

Hope this helps!

@DiegoBM
Copy link

DiegoBM commented Sep 12, 2017

Thank you @taha, it was worth the shot, but unfortunately in this case it seems to be something else. I tried what you suggested but I keep getting the same result

@taha
Copy link

taha commented Sep 12, 2017

@DiegoBM can you post your full error here? Possibly the full log till the error happened.

@DiegoBM
Copy link

DiegoBM commented Sep 12, 2017

log.txt
By all means, this is the second attempt to build, but I deleted the whole built and run both clean commands before trying your fix

@taha
Copy link

taha commented Sep 12, 2017

Can you attempt bootstraping from a fresh clone of the repo? And possibly post the log here as well.

Running the clean commands doesn't actually clear out the git submodules synced at the beginning of bootstrap.py script. The error your getting is most likely due to something that went wrong during the process of syncing the git submodules, since the files that are missing are in fact in the electron/node repo. The fact that they're missing means that an error stopped git from finishing the update/sync process of the node submodule.

@DiegoBM
Copy link

DiegoBM commented Sep 12, 2017

You were absolutely correct @taha, it worked flawlessly on a fresh new clone, after applying your suggestion. You are the man!

P.S: Sorry for the delay to reply, it took a good chunk of time to bootstrap twice (like with zombies, always double check) and confirm successful build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants