Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app.getGPUFeatureStatus in app.md #10499

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Fix app.getGPUFeatureStatus in app.md #10499

merged 1 commit into from
Sep 12, 2017

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Sep 12, 2017 •
edited

getGPUFeatureStatus is incorrectly documented as getGpuFeatureStatus, therefore electron.d.ts contains an incorrect method signature.

in atom/browser/api/atom_api_app.cc

      .SetMethod("getGPUFeatureStatus", &App::GetGPUFeatureStatus)

alespergl
alespergl approved these changes Sep 12, 2017
View reviewed changes
Copy link
Contributor

@alespergl alespergl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit :)

@miniak miniak merged commit ddb1d92 into electron:master Sep 12, 2017
@miniak miniak deleted the doc-fix branch September 12, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alespergl alespergl alespergl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miniak @alespergl