Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heading for README #12202

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Add heading for README #12202

merged 1 commit into from
Mar 9, 2018

Conversation

vanessayuenn
Copy link
Contributor

The electron/i18n module uses headings in each doc to separate it into sections, and it's not happy with the current headinglessness of README. 馃槃

@vanessayuenn vanessayuenn requested a review from a team March 9, 2018 19:21
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jkleinsc jkleinsc merged commit e085c01 into master Mar 9, 2018
@jkleinsc jkleinsc deleted the readme-heading branch March 9, 2018 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants