fix: Incorrect warnings in webviews #12234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hang my reviewer's head in shame |
|
An error occurred while attempting to backport this PR to "2-0-x", you will need to perform this backport manually |
|
#trop run backport |
|
The backport process for this PR has been manually initiated, here we go :D |
|
We have automatically backported this PR to "2-0-x", please check out #12236 |
sethlu
pushed a commit
to sethlu/electron
that referenced
this pull request
May 3, 2018
* 🔧 Get correct webContents * 🔧 Err, webPreferences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes incorrect security warnings in
webContentsthat aren't the current window'swebContents. It is unclear to me why I didn't just callgetCurrentWebContents()to begin with.Closes #12200