Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept-first-mouse does not work on -webkit-app-region: drag #1286

Closed
tommoor opened this issue Mar 23, 2015 · 5 comments · Fixed by #1288
Closed

accept-first-mouse does not work on -webkit-app-region: drag #1286

tommoor opened this issue Mar 23, 2015 · 5 comments · Fixed by #1288

Comments

@tommoor
Copy link
Contributor

tommoor commented Mar 23, 2015

If an element has the "-webkit-app-region: drag" css style (such as a title area) then even with "accept-first-mouse" in the window options the first click (and hold) to drag the window does not work.

Repro steps:

  • Create a frameless window with a webkit-app-region: drag
  • Focus another window
  • Click and hold on the draggable area and try and move the window
@bwin
Copy link
Contributor

bwin commented Mar 23, 2015

Cannot reproduce. Please provide the necessary details like Atom-Shell version, operating system version and architecture.

Edit: Works in Atom-Shell 0.22.1 32bit on Win7 64bit without accept-first-mouse.

@tommoor
Copy link
Contributor Author

tommoor commented Mar 23, 2015

@bwin Atom Shell 0.22.2 on Mac OSX 10.10.1.

I've tried with and without accept-first-mouse, always-on-top and resizeable.

@bwin
Copy link
Contributor

bwin commented Mar 23, 2015

Sorry can't help you there, I don't have a Mac here... (Just wait a little while and someone else will look into it.)

@zcbenz
Copy link
Member

zcbenz commented Mar 24, 2015

I can confirm it on Mac, it seems to be caused by ControlRegionView not implementing acceptFirstMouse.

@tommoor
Copy link
Contributor Author

tommoor commented Mar 24, 2015

Impressed gang, a fix in under 24 hours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants